Python autoinstrumentation for musl libc based application containers #2266
Conversation
|
|
ilyamochalov
force-pushed
the
ISSUE-2264-python-musl
branch
from
db1f2a7
to
4e8028f
Compare
ilyamochalov
force-pushed
the
ISSUE-2264-python-musl
branch
2 times, most recently
from
106da37
to
f36f69b
Compare
ilyamochalov
force-pushed
the
ISSUE-2264-python-musl
branch
from
f36f69b
to
4b2aead
Compare
| FROM busybox | ||
|
|
||
| COPY --from=build /operator-build/workspace /autoinstrumentation | ||
| COPY --from=build /operator-build/workspace /autoinstrumentation/linux-x64 |
There was a problem hiding this comment.
I am not sure how in details looks release process for docker images, but if it release new version just after merge to main it can be breaking change for currently released version.
If the new image will be applicable only to the new operator release - then it LGTM.
There was a problem hiding this comment.
A very good concern! I will check
|
@ilyamochalov I will have time to review this PR next week. Thank you for contributing. |
|
@ilyamochalov looks like there are some failing tests here, would you be able to take a look so we can get this in the next release? |
|
@jaronoff97 I will take a look at failing tests. When is the next release? |
|
Sometime next week, i believe. |
|
@jaronoff97 I am dragged into some other projects. I won't fix tests this week. Please go ahead and release without this change. |
|
no problem, thank you for letting me know. I hope to cut the release today. |
Description: adding musl build to python autoinstrumentation
Link to tracking Issue: #2264
Testing: updated e2e test and also added unit tests cases
Documentation: updated the README file